feat: add emoji argument #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axisiscool
suggested changes
Dec 26, 2021
favna
requested changes
Dec 26, 2021
favna
force-pushed
the
feature/arguments/emoji
branch
from
5fc4e1f
to
0f97dac
Compare
favna
added a commit
to sapphiredev/website
that referenced
this pull request
Dec 28, 2021
This should be merged alongside sapphiredev/framework#349
favna
previously approved these changes
Dec 28, 2021
vladfrangu
requested changes
Dec 28, 2021
favna
requested changes
Jan 10, 2022
noftaly
suggested changes
Jan 10, 2022
favna
requested changes
Jan 10, 2022
src/lib/resolvers/emoji.ts
Outdated
Comment on lines
13
to
24
| const emojiId = EmojiRegex.exec(parameter)?.groups?.id; | ||
|
|
||
| if (emojiId) { | ||
| const resolved = Util.parseEmoji(emojiId) as EmojiObject; | ||
|
|
||
| if (resolved) { | ||
| return ok(resolved); | ||
| } | ||
| } |
There was a problem hiding this comment.
This is always going to return false for animated as per how parseEmoji works: https://github.com/discordjs/discord.js/blob/12ffa069aa8b247e945fef16a543f41c2c391bf1/packages/discord.js/src/util/Util.js#L284-L298
Instead pass the full parameter into the method.
favna
force-pushed
the
feature/arguments/emoji
branch
from
c9d9892
to
924558b
Compare
vladfrangu
approved these changes
Jan 10, 2022
favna
approved these changes
Jan 10, 2022
favna
added a commit
to sapphiredev/website
that referenced
this pull request
Jan 12, 2022
This should be merged alongside sapphiredev/framework#349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this addition there will be a built-in argument for both global and guild emojis