feat: faster overwrites and string min max length support #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sapphiredev pack this |
|
Heya @vladfrangu, I've started to run the deployment workflow on this PR at 64f1b90. You can monitor the build here! |
|
Hey @vladfrangu, I've released this to NPM. You can install it for testing like so: npm install @sapphire/framework@pr-495 |
favna
reviewed
Jul 26, 2022
src/lib/utils/application-commands/ApplicationCommandRegistry.ts
Outdated
Show resolved
Hide resolved
favna
reviewed
Jul 26, 2022
Co-authored-by: Jeroen Claassens <support@favware.tech>
favna
approved these changes
Jul 27, 2022
c43721
reviewed
Jul 28, 2022
| @@ -36,7 +36,9 @@ | |||
| "@sapphire/result": "^1.1.1", | |||
| "@sapphire/stopwatch": "^1.4.1", | |||
| "@sapphire/utilities": "^3.7.0", | |||
| "@types/object-hash": "^2.2.1", | |||
There was a problem hiding this comment.
yeah otherwise people need to install them themselves or use skipLibCheck and seeing as we're a type-first framework that would be bad DX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess BREAKING CHANGE: RegisterBehavior.Overwrite is now the default behaviorWhenNotEqual, and it now uses object hashing instead of checking each property