Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the infinite difference found for commands #499

Merged
merged 4 commits into from
Aug 5, 2022

Conversation

vladfrangu
Copy link
Member

Closes #497 hopefully

@vladfrangu
Copy link
Member Author

@sapphiredev pack this pls

@sapphiredev
Copy link

sapphiredev bot commented Aug 4, 2022

Heya @vladfrangu, I've started to run the deployment workflow on this PR at 8c83113. You can monitor the build here!

@sapphiredev
Copy link

sapphiredev bot commented Aug 4, 2022

Hey @vladfrangu, I've released this to NPM. You can install it for testing like so:

npm install @sapphire/framework@pr-499

@vladfrangu
Copy link
Member Author

https://github.com/sapphiredev?type=source pack this pls

@vladfrangu
Copy link
Member Author

@sapphiredev pack this and ffs github copy paste

@sapphiredev
Copy link

sapphiredev bot commented Aug 4, 2022

Heya @vladfrangu, I've started to run the deployment workflow on this PR at 612bae2. You can monitor the build here!

@sapphiredev
Copy link

sapphiredev bot commented Aug 4, 2022

Hey @vladfrangu, I've released this to NPM. You can install it for testing like so:

npm install @sapphire/framework@pr-499

@vladfrangu
Copy link
Member Author

@sapphiredev pack this once more??

@sapphiredev
Copy link

sapphiredev bot commented Aug 4, 2022

Heya @vladfrangu, I've started to run the deployment workflow on this PR at 9800f28. You can monitor the build here!

@sapphiredev
Copy link

sapphiredev bot commented Aug 4, 2022

Hey @vladfrangu, I've released this to NPM. You can install it for testing like so:

npm install @sapphire/framework@pr-499

@vladfrangu
Copy link
Member Author

@sapphiredev pack this

@sapphiredev
Copy link

sapphiredev bot commented Aug 4, 2022

Heya @vladfrangu, I've started to run the deployment workflow on this PR at b9dcd4c. You can monitor the build here!

@sapphiredev
Copy link

sapphiredev bot commented Aug 4, 2022

Hey @vladfrangu, I've released this to NPM. You can install it for testing like so:

npm install @sapphire/framework@pr-499

@EvolutionX-10
Copy link
Contributor

Was the issue with object-hash??

@vladfrangu
Copy link
Member Author

Yes and no. It's just not efficient enough for our needs 😅

@EvolutionX-10
Copy link
Contributor

Oh okay, thanks for fixing it!!! I will try the PR soon

@favna favna changed the title chore: hopefully fix the infinite difference found for commands fix: fixed the infinite difference found for commands Aug 5, 2022
@favna favna merged commit 1e11f53 into main Aug 5, 2022
@favna favna deleted the fix/always-finding-differences branch August 5, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: incorrect conversions in object hashing
3 participants