Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: resolve interactions #503

Merged
merged 5 commits into from
Aug 14, 2022
Merged

feat: resolve interactions #503

merged 5 commits into from
Aug 14, 2022

Conversation

samfundev
Copy link
Contributor

@samfundev samfundev commented Aug 6, 2022 •
edited by favna

Closes #358

Squash commit body:

BREAKING CHANGE: `CoreMessage` argument and `resolveMessage` used to have an option `message`, this has been renamed to `messageOrInteraction` to properly cover the scope it covers.

@samfundev samfundev marked this pull request as ready for review August 7, 2022 14:58
@favna favna added this to the v3 milestone Aug 9, 2022
vladfrangu
vladfrangu requested changes Aug 13, 2022
View reviewed changes
src/lib/resolvers/message.ts Outdated Show resolved Hide resolved
src/lib/utils/resolvers/resolveId.ts Outdated Show resolved Hide resolved
src/lib/utils/resolvers/resolveId.ts Outdated Show resolved Hide resolved
src/lib/utils/resolvers/resolveId.ts Outdated Show resolved Hide resolved
@favna favna merged commit a09b4c2 into sapphiredev:main Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favna favna favna approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@c43721 c43721 c43721 approved these changes

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Sapphire
Status: Done
Milestone
v3
Development

Successfully merging this pull request may close these issues.

Parse interaction options with sapphire resolvers
4 participants
@samfundev @favna @vladfrangu @c43721