-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed args#restResult
including leading space
#531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyranet
requested changes
Sep 17, 2022
kyranet
previously approved these changes
Sep 18, 2022
favna
requested changes
Sep 20, 2022
Co-authored-by: Jeroen Claassens <jeroen.claassens@live.nl>
kyranet
approved these changes
Sep 21, 2022
favna
approved these changes
Sep 21, 2022
vladfrangu
approved these changes
Sep 21, 2022
args#restResult
including leading space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the leading space when using
Args#rest()
andArgs#restResult()
on arguments after the first one. This was achieved by removing the insertion of theparamater.leading
value on the first reduction done byArray#reduce()
, but keeping it for all others (if it isn't kept, the result would have no spaces kindalikethis). Test images and the code used to generate the images are below. I also added*.tgz
to.gitingore
as that was generated when I usedyarn pack
to test the changes.Before
After
Test command file used
This PR closes #529