Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ApplicationCommandRegistry): context menu command matching went wrong #590

Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix(ApplicationCommandRegistry): context menu command matching went wrong #590

merged 1 commit into from
Jan 11, 2023

Conversation

vladfrangu
Copy link
Member

@vladfrangu
Copy link
Member Author

@sapphiredev pack this

@sapphiredev
Copy link

sapphiredev bot commented Jan 10, 2023

Heya @vladfrangu, I've started to run the deployment workflow on this PR at 79c4f79. You can monitor the build here!

@sapphiredev
Copy link

sapphiredev bot commented Jan 10, 2023

Hey @vladfrangu, I've released this to NPM. You can install it for testing like so:

npm install @sapphire/framework@pr-590

@vladfrangu
Copy link
Member Author

Confirmed that the linked thread is fixed with this PR

@vladfrangu vladfrangu enabled auto-merge (rebase) January 11, 2023 09:39
@vladfrangu vladfrangu enabled auto-merge (squash) January 11, 2023 09:40
@vladfrangu vladfrangu merged commit 779dda4 into main Jan 11, 2023
@vladfrangu vladfrangu deleted the fix/context-menu-commands-dont-match-properly branch January 11, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@favna favna favna approved these changes

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner

Assignees
No one assigned
Labels
priority:critical semver:patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vladfrangu @favna