fix(Args): ensure proper error types are always thrown #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the `result.unwrap()` calls to `result.unwrapRaw()` to ensure that the erorr that gets thrown for the following methods: - `args.pick(...)` - `args.rest(...)` - `args.repeat(...)` - `args.peek(...)` This makes it so that the error that ends up in `messageCommandError` listener will have the proper error type. Furthermore, it can also be handled properly when chaining `.catch()` calls to the `args.X` method. resolves #528
favna
force-pushed
the
fix/fixed-args-unwrapping
branch
from
3b9e65c
to
59fd66a
Compare
vladfrangu
approved these changes
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
result.unwrap()calls toresult.unwrapRaw()to ensure that the erorr that gets thrown for the following methods:args.pick(...)args.rest(...)args.repeat(...)args.peek(...)This makes it so that the error that ends up inmessageCommandErrorlistener will have the proper error type. Furthermore, it can also be handled properly when chaining.catch()calls to theargs.Xmethod.resolves #528
Reproduced the error first with https://github.com/favna/musical-giggle, then confirmed the fix using a debugger with the code from the issue. Also confirmed that it is resolved for
Args.makeby copying the code from https://github.com/favna/repro-sapphire-unwrap-error which was created for a separately reported issue.