Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-export more types from @sapphire/pieces #715

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

favna
Copy link
Member

@favna favna commented Jan 10, 2024

Some of these really should've always been there (like AliesPieceJSON and PieceJSON) but I noticed this when trying to import StoreRegistryValue which is the type of store in:

for (const store of this.container.stores.values()) {

}

so previously you couldn't pass store into a receiver function as happens in sapphiredev/examples without adding an import from @sapphire/pieces when for all other purposes you only need to import from @sapphire/framework.

Signed-off-by: Jeroen Claassens <jeroen.claassens@live.nl>
@favna favna merged commit 662f212 into main Jan 10, 2024
8 checks passed
@favna favna deleted the fix/re-export-more-store-types branch January 10, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants