feat(plugin-i18n): add new syntax for formatters in i18next #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c43721
changed the title
vladfrangu
requested changes
Nov 8, 2021
vladfrangu
reviewed
Nov 8, 2021
vladfrangu
approved these changes
Nov 8, 2021
favna
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to the
InternationalizationOptionscalledformatterswhich takes in aI18nextFormattersarray to add to i18n via thei18next.services.formatter.addsyntax, as described in https://www.i18next.com/translation-function/formatting#basic-usage.Goal here is to move off the old, deprecated syntax and move to the new syntax, as the old way of adding formatters is considered deprecated in i18n version 21, described in https://www.i18next.com/translation-function/formatting#legacy-format-function-i18next-less-than-21.3.0.