Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subcommands): type improvements & fix build #59

Merged
merged 3 commits into from Feb 12, 2021

Conversation

favna
Copy link
Member

@favna favna commented Feb 12, 2021

No description provided.

- defaults for type generics
- better names for type generics
- README
- peer dependencies
- cleanup files array
vladfrangu
vladfrangu previously approved these changes Feb 12, 2021
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The names are monkaw, fine otherwise

packages/subcommands/README.md Outdated Show resolved Hide resolved
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as I don't have to read those types breaking into different lines myself... LGTM

@kyranet kyranet merged commit 1707d01 into main Feb 12, 2021
@kyranet kyranet deleted the feat/subcommand-improvements branch February 12, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants