Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should physicalLocation disappear? #218

Open
ghost opened this issue May 24, 2016 · 0 comments
Open

Should physicalLocation disappear? #218

ghost opened this issue May 24, 2016 · 0 comments
Labels
discussion-ongoing impact-breaks-consumers impact-breaks-producers
Milestone
future

Comments

@ghost
Copy link

ghost commented May 24, 2016

We'd replace location.analysisTarget with location.analysisTargetUri, replace location.resultFile with location.resultFileUri, and introduce property location.region.

The rationale is that you never need a region on both of analysis target and result file.

The initial motivation for considering this change was the introduction of run.analysisTargetUri. We originally considered calling it run.analysisTarget and making it a physicalLocation object whose region would never be used.

@michaelcfanning FYI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion-ongoing impact-breaks-consumers impact-breaks-producers
Projects
None yet
Milestone
future
Development

No branches or pull requests
0 participants