Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should physicalLocation disappear? #19

Closed
ghost opened this issue Sep 26, 2017 · 0 comments
Closed

Should physicalLocation disappear? #19

ghost opened this issue Sep 26, 2017 · 0 comments

Comments

@ghost
Copy link

ghost commented Sep 26, 2017

Copied from sarif-standard/sarif-spec-v1#218, created by @lgolding:

We'd replace location.analysisTarget with location.analysisTargetUri, replace location.resultFile with location.resultFileUri, and introduce property location.region.

The rationale is that you never need a region on both of analysis target and result file.

The initial motivation for considering this change was the introduction of run.analysisTargetUri. We originally considered calling it run.analysisTarget and making it a physicalLocation object whose region would never be used.

@michaelcfanning FYI

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

0 participants