Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre cleanup for PR #8

Merged
merged 4 commits into from
Oct 17, 2021
Merged

Pre cleanup for PR #8

merged 4 commits into from
Oct 17, 2021

Conversation

sarnold
Copy link
Owner

@sarnold sarnold commented Oct 15, 2021

@pep8speaks
Copy link

pep8speaks commented Oct 15, 2021

Hello @sarnold! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 186:80: E501 line too long (88 > 79 characters)
Line 187:80: E501 line too long (80 > 79 characters)

Comment last updated at 2021-10-17 21:52:09 UTC

* test docs command fix => use check_call and fstrings
* test ioggstream/bandit-report-artifacts#6

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
* bot appears to be ignoring old-style cfg section
* update coverage badge, limit conda workflow to push

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
* update pre-commit cfg and readme

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity
pystache 99% 97% 0
commands 93% 50% 0
Summary 99% (636 / 645) 96% (183 / 190) 0

@github-actions
Copy link

Hello @sarnold! Thanks for opening this PR. We found the following information based on analysis of the coverage report:

Base Branch Rate coverage is 96%
Merging 9d6cb43 into master will not change coverage

Nice work, @sarnold. Cheers! 🍻

@sarnold sarnold merged commit f2b285a into master Oct 17, 2021
sarnold added a commit that referenced this pull request Oct 18, 2021
fix: dev: update pre-commit hooks, fix some warnings

* cleanup bandit warning, update workflows and pre-commit cfg
* switch pep8speaks flake8 section to yaml, update workflows
* update coverage badge, limit conda workflow to push
* add some pre-commit and gitchangelog (developer) docs
* update pre-commit cfg and readme

Signed-off-by: Stephen L Arnold <nerdboy@gentoo.org>
@sarnold sarnold deleted the pr-cleanup branch April 10, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants