[INTERNAL][E] Introduce reference point based resource implementation #1023
Conversation
tobous
force-pushed
the
pr/core/clean-up-for-ref-point
branch
from
870e843
to
571ef80
Compare
tobous
force-pushed
the
pr/eclipse/introduce-new-ref-point-resource-impl
branch
from
039a1dd
to
f90b06f
Compare
|
Rebased onto current master without any interaction. |
tobous
force-pushed
the
pr/eclipse/introduce-new-ref-point-resource-impl
branch
from
f90b06f
to
a4104ae
Compare
|
Addressed review issues. Rebased onto current master. Fixed minor issues with implementation found during migration. |
|
This PR should be ready to review now. |
tobous
force-pushed
the
pr/eclipse/introduce-new-ref-point-resource-impl
branch
from
a4104ae
to
2f83cce
Compare
|
Rebased onto current master without any interaction. |
The encoding handling in general needs improvement. See #912 and #940. As the logic to set the folder charset is currently never used, I would like to keep it the way it is for now. But extending the |
|
As this has been approved for a while now and does not actually change any of the logic of Saros/E but rather just adds dead code (for now), I decided to merge this now even though the rest of the PR stack has not been fully reviewed. |
Adds new resource implementation based on the reference point model. The new resource implementation somewhat resembles the new IntelliJ resource implementation. This is due to both implementations now operating on the same resource model and being bound by the same restrictions (i.e. the Eclipse implementation now also having to deal with relative resources instead of solely relying on the Eclipse delegates). Adds ResourceConverter as a replacement for ResourceAdapterFactory. Marks the old resource implementations as deprecated. Marks ResourceAdapterFactory as deprecated and removes an unused method.
Adjusts the logic to set the encoding for a file to check the direct parent when trying to inherit the encoding instead of the project. This was done to match the underlying Eclipse logic which always looks at the direct parent container instead of the project default.
tobous
force-pushed
the
pr/eclipse/introduce-new-ref-point-resource-impl
branch
from
2f83cce
to
5172f51
Compare
|
Rebased onto current master without any interaction. |
|
Complexity increasing per file
==============================
- eclipse/src/saros/filesystem/EclipseReferencePointImpl.java 7
- eclipse/src/saros/filesystem/EclipseFolderImplV2.java 7
- eclipse/src/saros/filesystem/ResourceConverter.java 5
- eclipse/src/saros/filesystem/EclipseFileImplV2.java 4
- eclipse/src/saros/filesystem/EclipseResourceImplV2.java 5
Clones added
============
- eclipse/src/saros/filesystem/EclipseFileImplV2.java 2
- eclipse/src/saros/filesystem/EclipseFileImpl.java 2
See the complete overview on Codacy |
This is my current draft for the new Eclipse resource implementation. The details of the implementation might still change a bit if I encounter any trouble while migrating Saros/E to the new resource implementation but should be stable in general.
A full review of the class is not sensible quite yet (as it still might change), but I would appreciate some feedback on the general design of the implementation.
Commits
[INTERNAL][E] Introduce reference point based resource implementation
Adds new resource implementation based on the reference point model.
The new resource implementation somewhat resembles the new IntelliJ
resource implementation. This is due to both implementations now
operating on the same resource model and being bound by the same
restrictions (i.e. the Eclipse implementation now also having to deal
with relative resources instead of solely relying on the Eclipse
delegates).
Adds ResourceConverter as a replacement for ResourceAdapterFactory.
Marks the old resource implementations as deprecated.
Marks ResourceAdapterFactory as deprecated and removes an unused method.