pr/IntroduceReferencePointAndRefactoringSarosSession #211
Conversation
core.IReferencePoint
SharedReferencePointMapper
…oject/saros into IntroduceReferencePoint
addReferencePoint()
| * the resources to add | ||
| */ | ||
| /* | ||
| * TODO needs proper sync. in the SarosSession class |
There was a problem hiding this comment.
| * the resources to remove | ||
| */ | ||
| /* | ||
| * TODO needs proper sync. in the SarosSession class |
There was a problem hiding this comment.
| + " [completely shared:" + !isPartially + "]"); | ||
| } | ||
|
|
||
| private synchronized void CheckIfReferencePointIsAbleToBeShared(String id, |
There was a problem hiding this comment.
| IReferencePoint referencePoint) { | ||
|
|
||
| if (partiallySharedReferencePoints.contains(referencePoint)) | ||
| throw new IllegalStateException("referencePoint " + referencePoint |
There was a problem hiding this comment.
| } | ||
| } | ||
|
|
||
| private synchronized void addReferencePointPartially(String id, |
There was a problem hiding this comment.
| * <p> | ||
| * TODO Why is the project parameter needed here? This forces callers to | ||
| * store the mapping themselves (or retrieve it just before calling this | ||
| * TODO Why is the referencePoint parameter needed here? This forces callers |
There was a problem hiding this comment.
| return false; | ||
|
|
||
| if (isCompletelyShared(referencePoint)) | ||
| // TODO how should partial sharing handle this case ? |
There was a problem hiding this comment.
| * Negotiation, since its the only consumer of queuing | ||
| * functionality. This will enable a specific Queuing mechanism per | ||
| * TransferType (see github issue #137). | ||
| * TODO Queuing responsibility should be moved to Project Negotiation, |
There was a problem hiding this comment.
| new HashSet<IResource>()); | ||
| } | ||
|
|
||
| private synchronized void addReferencePointCompletelly(String id, |
There was a problem hiding this comment.
| * the resources to add | ||
| */ | ||
| /* | ||
| * TODO needs proper sync. in the SarosSession class |
There was a problem hiding this comment.
|
It seems like you started to split this pull request (see #227). Can this PR be closed? |
No description provided.