[INTERNAL][CORE] Removes deprecated methods from XMPPAccountStore #615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces get/set defaultAccount methods which should be a replacement for set/get activeAccount in the future. They allow null values making the call to isEmpty obsolete. And now it is also possible to completely remove all account data. Add getAccount methods as there was no way to retrieve specific account unless you called getAllAccounts and perform the search by yourself.
This patch introduces the usage of the new XMPPStore API. Renaming UI buttons is not done yet as changing UI values is likely to crash the whole STF.
This patch also fixes an issue in the getAccountsMethods so they lookup the account correctly by ignoring the case sensitivity of the username. Adds a FIXME to the XMPPAccount class regarding RFC 6122
srossbach
force-pushed
the
pr/use_new_accountstore_api
branch
2 times, most recently
from
362e2b6
to
e4ba631
Compare
|
I guess @m273d15 have to review this first as this patch may cause issues in the HTML UI. |
tobous
approved these changes
Aug 5, 2019
| @@ -51,6 +51,9 @@ | |||
| if (!domain.toLowerCase().equals(domain)) | |||
| throw new IllegalArgumentException("domain url must be in lower case letters"); | |||
|
|
|||
| // FIXME see https://tools.ietf.org/html/rfc6122#section-2 - the localpart/username is also | |||
| // case-insensitive | |||
There was a problem hiding this comment.
My assumption is that this means we should add a check (equivalent to the checks for server and domain above). Either way, I think it would be better to spell out exactly what you want to happen to ensure that the fixme is interpreted correctly.
There was a problem hiding this comment.
The problem I have is I do not know how XStream works. What happens if we load the set after changing the equal method of this class ? Can I ensure that duplicates got removed or do I have to manually "fix" the set ?
tobous
requested changes
Aug 5, 2019
|
@srossbach would you like to continue working on this pr or should we close it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[INTERNAL][CORE] Removes deprecated methods from XMPPAccountStore
This patch also fixes an issue in the getAccountsMethods so they lookup
the account correctly by ignoring the case sensitivity of the username.
Adds a FIXME to the XMPPAccount class regarding RFC 6122