[INTERNAL] Remove IWorkspaceRoot #950
Conversation
|
Instead of keeping |
|
|
||
| /** Eclipse implementation of {@link IWorkspaceRoot}. */ | ||
| public class EclipseWorkspaceRootImpl extends EclipseContainerImpl implements IWorkspaceRoot { | ||
| /** Eclipse {@link IContainer} implementation representing an {@link IWorkspaceRoot}. */ |
There was a problem hiding this comment.
Is this class deleted in another patch ?
There was a problem hiding this comment.
No, I didn't remove it because it is still used in the eclipse implementation. If a file in the workspace root asks for its parent resource, a workspace root object is returned instead of a folder. This class is now used as a simple implementation of the abstract EclipseContainerImpl. But I could also remove the abstract modifier from EclipseContainerImpl and change the delegate type to IContainer instead of IReosurce if you would prefer.
There was a problem hiding this comment.
But I could also remove the abstract modifier from EclipseContainerImpl and change the delegate type to IContainer instead of IReosurce if you would prefer
Do you think the additional abstraction layer EclipseWorkspaceRootImpl provides valuable information? Otherwise, I would prefer your idea of removing the class and using the EclipseContainerImpl.
There was a problem hiding this comment.
Do you think the additional abstraction layer
EclipseWorkspaceRootImplprovides valuable information?
No, not really as I couldn't be bothered to added any new javadoc to it. Will adjust the container implementation and remove the class.
tobous
force-pushed
the
pr/core/remove-iworkspaceroot
branch
from
d10e489
to
558d5d5
Compare
|
Rebased onto current master fixing minor merge conflicts. |
|
Removed 'abstract' modifier from |
Removes the interface IWorkspaceRoot as it was no longer being used. Removes the IntelliJ implementation of IWorkspaceRoot. Removes the interface declaration from EclipseWorkspaceRoot. This implementation remains as it is still used when requesting the parent container of a resource located in the workspace root.
Removes the abstract modifier from the class EclipseContainerImpl. Uses EclipseContainerImpl as a replacement for EclipseWorkspaceRootImpl as the class no longer contained any methods. Removes EclipseWorkspaceRootImpl.
tobous
force-pushed
the
pr/core/remove-iworkspaceroot
branch
from
46dfba4
to
2e35d3d
Compare
|
Rebased onto current master without any interaction. |
Removes the interface IWorkspaceRoot as it was no longer being used.
Removes the IntelliJ implementation of IWorkspaceRoot.
Removes the interface declaration from EclipseWorkspaceRoot. This
implementation remains as it is still used when requesting the parent
container of a resource located in the workspace root.