[FIX][CORE] Fix handling of empty selection in text selection activity #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts TextSelectionActivity.getSelection() to correctly return TextSelection.EMPTY_SELECTION if all selection values are -1. Adds an exception if only some values are -1. This should in theory not be possible as a valid handling of all >=0 or all ==-1 is enforced by the TextSelection constructor.
tobous
added
Type: Bug
|
This patch applies cleanly to |
|
Complexity increasing per file
==============================
- core/src/saros/activities/TextSelectionActivity.java 6
See the complete overview on Codacy |
m273d15
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts TextSelectionActivity.getSelection() to correctly return
TextSelection.EMPTY_SELECTION if all selection values are -1.
Adds an exception if only some values are -1. This should in theory not
be possible as a valid handling of all >=0 or all ==-1 is enforced by
the TextSelection constructor.