Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve Aspect Ratio #41

Closed
mk79 opened this issue Oct 29, 2016 · 9 comments
Closed

Preserve Aspect Ratio #41

mk79 opened this issue Oct 29, 2016 · 9 comments

Comments

@mk79
Copy link

mk79 commented Oct 29, 2016

First of all, thanks for the Plugin.

I wonder if it is possible to preserve the aspect ratio of the image - the image always stretches over the whole width and height of the screen.

Is this possible?

Thanks.

@jlno
Copy link

jlno commented Oct 30, 2016

+1

@sarriaroman
Copy link
Owner

Can you please tell me if Android or iOS? Thanks!

@sarinsukumar
Copy link

This commit has broken behavior.
9f200b1

@mk79
Copy link
Author

mk79 commented Nov 3, 2016

@sarriaroman it's on Android (Samsung Galaxy S7)

@sarriaroman
Copy link
Owner

sarriaroman commented Nov 3, 2016

@sarinsukumar @mk79 sadly the fix was made to avoid problems with images bigger than 100kb. Maybe a PR can be created to make it conditional but introduces the problem of the images again. I'm trying with a different library but still in testing.
Maybe works for you just change the plugin from the android project but take care of the size of the image because your app will blow up.

@sarinsukumar
Copy link

Ok, l will probably look to fix it, will update you.

Best Regards

Sarin sukumar A

On Thu, Nov 3, 2016 at 6:24 PM, Román A. Sarria notifications@github.com
wrote:

@sarinsukumar https://github.com/sarinsukumar @mk79
https://github.com/mk79 sadly the fix was made to avoid problems with
images bigger than 100kb. Maybe a PR can be created to make it conditional
but introduces the problem of the images again. I'm trying with a different
library but still in testing.
Maybe works for y


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#41 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAzEhh82lEgh0Iyn-Z-JxXU2UCQrECcQks5q6dl1gaJpZM4KkPyS
.

@sarinsukumar
Copy link

Is there a way I can change plugin source from the project ? will it reflect ? I tried but not reflecting the changes. I think may be we can resize the image while showing it to restrict within certain size.

@ekrapfl
Copy link

ekrapfl commented Nov 23, 2016

I have submitted a pull request to correct the issue.

@dawidfiruzek
Copy link
Contributor

Created pull request with fix to preserve the aspect ratio of the images #45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants