Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev.mod - PP1/PP2 error #1589

Closed
madhurrya opened this issue May 22, 2024 · 9 comments
Closed

dev.mod - PP1/PP2 error #1589

madhurrya opened this issue May 22, 2024 · 9 comments

Comments

@madhurrya
Copy link
Contributor

madhurrya commented May 22, 2024

When the requestor submits a PP1/PP2 form without adding any Supporting Information then it gives this error. First I thought it was a model issue, that's why I asked KB to update the models. But the same happen after that also.
It works in test.app/test.mod so it's not a model issue.

(May be it's similar to the issue Dinithi had with the inclusive gateway?)

https://dev.mod.spiff.status.im/i/39274
https://dev.mod.spiff.status.im/i/39276

Image

Image

@burnettk
Copy link
Contributor

is it the same issue as #1575, where some variables that were previously set to null are now absent? FYI, @calexh-sar

@madhurrya
Copy link
Contributor Author

@burnettk so the model has to be updated?

@burnettk
Copy link
Contributor

yeah

@burnettk
Copy link
Contributor

i updated three variables in PP1 on dev.app. There were del(blah) commands that were not working until i wrapped them in try / except NameError blocks, like this:

# delete team_id if it exists
try:
    del(team_id)
except NameError:
    pass

@madhurrya
Copy link
Contributor Author

Now it's giving this error
image

https://dev.app.spiff.status.im/i/2209

@sashayar13
Copy link
Collaborator

@burnettk, where exactly did you update the variables? do you remember what were the variables?

@sashayar13
Copy link
Collaborator

@madhurrya this error is related to the change I introduced to fix the issue you mentioned originally #1589 (comment)

try: supporting_information except NameError: supporting_information = ""

@sashayar13
Copy link
Collaborator

Fixed the issue in dev.app - promoted to test.app and uat.mod

@madhurrya
Copy link
Contributor Author

This issue is fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

No branches or pull requests

3 participants