Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev.mod/qa1 Inclusive Gateways giving an error when only some path conditions are true #1575

Closed
dinithihj opened this issue May 21, 2024 · 5 comments

Comments

@dinithihj
Copy link

On dev.mod and qa1 servers Inclusive gateways are causing errors when only some path conditions are true. They work fine when all path conditions are true.

Errored Instance on dev.mod - https://dev.mod.spiff.status.im/i/39004
Errored Instance on qa1 - https://qa1.spiffcrm.com/i/628

The same model with the same data selection on dev.app - https://dev.app.spiff.status.im/i/1667

@madhurrya
Copy link
Contributor

Tested another inclusive gateway with just script tasks and it seems to be working fine. https://qa1.spiffcrm.com/i/635
Not sure whether the above issue is related to the form/check boxes used there. We might need to investigate more on this.

@jasquat
Copy link
Contributor

jasquat commented May 21, 2024

I think this is a process model issue. The condition tries to call the variable but that variable is never set. You could have a post script that sets the variable if not already or the conditions could be updated to check for the existence of the variable.

@madhurrya
Copy link
Contributor

@jasquat But the same model works in dev.app as Dinithi has mentioned above. So it can't be a model issue I guess?

@jasquat
Copy link
Contributor

jasquat commented May 21, 2024

New rjsf only seems to pass in pieces that have been interacted with. So if you click on the checkbox and then uncheck it, then the value will be set to false, however if you do not click on the checkbox at all, then this field is never passed in. Currently the only way around that is to set a default value for the fields. In this case, setting the checkboxes default values to "default": false allows the variables to be set.

This change may be confusing for users but we may have to accept it as a permanent change. There are some hacks we could do if it really becomes a problem but setting the default values may be the more correct thing to do.

@dinithihj
Copy link
Author

Tested again on dev.mod and qa1 servers after setting checkboxes default value to false. Now it is working as expected.
Closing this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Resolved
Development

No branches or pull requests

3 participants