-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bpmn js spiff for data stores update #969
Conversation
WalkthroughWalkthroughThe update involves changing the dependency reference for Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -31,7 +31,7 @@ | |||
"axios": "^0.27.2", | |||
"bpmn-js": "^13.2.2", | |||
"bpmn-js-properties-panel": "^1.22.0", | |||
"bpmn-js-spiffworkflow": "github:sartography/bpmn-js-spiffworkflow#bd16223ccf02e1b64fe01e234809239817afa9a6", | |||
"bpmn-js-spiffworkflow": "github:sartography/bpmn-js-spiffworkflow#main", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relying on the main
branch for the bpmn-js-spiffworkflow
dependency can introduce instability. Consider pinning this dependency to a specific release tag or commit hash to ensure more predictable builds and dependency management.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's pinned elsewhere, dogg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@burnettk, based on the search results, the specific version of bpmn-js-spiffworkflow
is indeed pinned in the package-lock.json
file to commit ebeb194a0b3c67b9b3290d3d9ce324411824422c
. This ensures that despite the reference to the main
branch in package.json
, a specific commit is used during installations, providing the stability needed. Thank you for pointing this out.
Analysis chain
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for files mentioning 'bpmn-js-spiffworkflow' to find where it might be pinned.
rg "bpmn-js-spiffworkflow"
Length of output: 2403
bpmn js spiff data stores update
Summary by CodeRabbit
bpmn-js-spiffworkflow
dependency to track themain
branch, ensuring users have access to the latest features and fixes.