Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update bpmn js spiff for data stores update #969

Merged
merged 1 commit into from
Feb 5, 2024
Merged

update bpmn js spiff for data stores update #969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions spiffworkflow-frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion spiffworkflow-frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"axios": "^0.27.2",
"bpmn-js": "^13.2.2",
"bpmn-js-properties-panel": "^1.22.0",
"bpmn-js-spiffworkflow": "github:sartography/bpmn-js-spiffworkflow#bd16223ccf02e1b64fe01e234809239817afa9a6",
"bpmn-js-spiffworkflow": "github:sartography/bpmn-js-spiffworkflow#main",
Copy link
Contributor

@coderabbitai coderabbitai bot Feb 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relying on the main branch for the bpmn-js-spiffworkflow dependency can introduce instability. Consider pinning this dependency to a specific release tag or commit hash to ensure more predictable builds and dependency management.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's pinned elsewhere, dogg.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@burnettk, based on the search results, the specific version of bpmn-js-spiffworkflow is indeed pinned in the package-lock.json file to commit ebeb194a0b3c67b9b3290d3d9ce324411824422c. This ensures that despite the reference to the main branch in package.json, a specific commit is used during installations, providing the stability needed. Thank you for pointing this out.

Analysis chain
Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for files mentioning 'bpmn-js-spiffworkflow' to find where it might be pinned.
rg "bpmn-js-spiffworkflow"

Length of output: 2403

"cookie": "^0.5.0",
"craco": "^0.0.3",
"date-fns": "^2.28.0",
Expand Down
Loading