-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weighting branch changes #267
Conversation
Signed-off-by: Advay Ratan <advayratan@gmail.com>
Signed-off-by: Advay Ratan <advayratan@gmail.com>
seems like the commit history stuff is fixed. I'll check over the code and we can hopefully get this merged. |
I haven't gone through everything yet, but somethings I noticed while testing it.
|
I'm not having this problem I have made the change for point 1. As for point 2, that happens often when teachers edit the weighting of one assignment in a category. Nothing we can do about it unless we try to weigh each assignment separately. |
Signed-off-by: Advay Ratan <advayratan@gmail.com>
To try and replicate the default view, can you try and reinstall the extension after wiping extension storage? I'll test on another browser as well to see if it's replicable. |
finished going through it and found a few minor issues. once that's all fixed it seems to be good to merge. |
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
I made various changes if you want to look over it prior to merge @ARtheboss. Mostly some fixes but also added a sort to category view to maintain consistency in the view. Otherwise it'll show a different ordering after saving / reloading. New categories will still do that though which is fine. |
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
I also changed it to use percentages instead of decimal. Can you please check if I broke anything in the process @ARtheboss? Also if you can test it with missing assignments that'd be great as I'm unable to do that. Should be good to merge after that. |
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Advay Ratan advayratan@gmail.com