Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weighting branch changes #267

Merged
merged 15 commits into from
Mar 26, 2021
Merged

Weighting branch changes #267

merged 15 commits into from
Mar 26, 2021

Conversation

ARtheboss
Copy link
Collaborator

Signed-off-by: Advay Ratan advayratan@gmail.com

Signed-off-by: Advay Ratan <advayratan@gmail.com>
Signed-off-by: Advay Ratan <advayratan@gmail.com>
@Suhas-13
Copy link
Member

Suhas-13 commented Feb 2, 2021

seems like the commit history stuff is fixed. I'll check over the code and we can hopefully get this merged.

@Suhas-13
Copy link
Member

Suhas-13 commented Mar 3, 2021

I haven't gone through everything yet, but somethings I noticed while testing it.

  1. Increments defaults to 1, this should definitely be at 0.1 or lower as 1 is the maximum.
  2. The calculation doesn't seem to be correct for some classes as well, I'll check it out in more depth later to try and figure out what's going on.
  3. It defaults to showing the category weights view even when no option is selected

@ARtheboss
Copy link
Collaborator Author

ARtheboss commented Mar 6, 2021

  1. It defaults to showing the category weights view even when no option is selected

I'm not having this problem

I have made the change for point 1.

As for point 2, that happens often when teachers edit the weighting of one assignment in a category. Nothing we can do about it unless we try to weigh each assignment separately.

Signed-off-by: Advay Ratan <advayratan@gmail.com>
@Suhas-13
Copy link
Member

To try and replicate the default view, can you try and reinstall the extension after wiping extension storage? I'll test on another browser as well to see if it's replicable.

@Suhas-13
Copy link
Member

finished going through it and found a few minor issues. once that's all fixed it seems to be good to merge.

Suhas Hariharan added 7 commits March 24, 2021 19:39
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
@Suhas-13
Copy link
Member

I made various changes if you want to look over it prior to merge @ARtheboss. Mostly some fixes but also added a sort to category view to maintain consistency in the view. Otherwise it'll show a different ordering after saving / reloading. New categories will still do that though which is fine.

Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
@Suhas-13
Copy link
Member

I also changed it to use percentages instead of decimal. Can you please check if I broke anything in the process @ARtheboss? Also if you can test it with missing assignments that'd be great as I'm unable to do that. Should be good to merge after that.

Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
@Suhas-13 Suhas-13 requested a review from priime0 March 24, 2021 12:40
Suhas Hariharan added 2 commits March 25, 2021 11:54
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
Signed-off-by: Suhas Hariharan <hariharan774531@sas.edu.sg>
@Suhas-13 Suhas-13 merged commit 2c631e7 into master Mar 26, 2021
@Suhas-13 Suhas-13 added the feature New feature addition label Apr 5, 2021
@megagames-me megagames-me deleted the weighting7 branch January 9, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants