Drop dependency for failure crate, and make NodeId::remove() infallible
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node removal is infallible if the tree is consistent.
Insertion error (`NodeError`) is quite simple. `failure` is too powerful and heavy for it.
This makes addition of error variant non-breaking. See <https://github.com/rust-lang/rfcs/blob/master/text/2008-non-exhaustive.md#how-we-do-this-today>.
lo48576
force-pushed
the
feature/drop-failure
branch
from
cc4a27d
to
eefcc8f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking change.
failurebrings some dependencies, but errors inindextreeis quite simple ("preconditions are not met"), and it is almost unnecessary.NodeId::remove()is now infallible.NodeId::insert_{before,after},NodeId::{prepend,append}now returnsResult<(), NodeError>instead offailure::Fallible<()>.failurecrate for these simple errors..unwrap()explicitly, intead of using?operator.