Fix removal of complex subtrees #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous code had incorrect preorder traversal in
NodeId::remove_subtree. Upon return upwards in the tree, if a cursor's
parent didn't have a sibling, the algorithm would terminate without
looking at more distant ancestors which still might have some siblings
that needed removing.
In the following example arena, when removing node 1_2, node 1_2_2
should be marked as removed but it wasn't:
arena
`-- 1
|-- 1_1
|-- 1_2
| |-- 1_2_1
| | `-- 1_2_1_1
| | `-- 1_2_1_1_1
| `-- 1_2_2
`-- 1_3
This issue with returning upwards in ancestors chain is now fixed. A
new test case is added with the above example scenario.
Resolves: saschagrunert#71
saschagrunert
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code had incorrect preorder traversal in
NodeId::remove_subtree. Upon return upwards in the tree, if a cursor's
parent didn't have a sibling, the algorithm would terminate without
looking at more distant ancestors which still might have some siblings
that needed removing.
In the following example arena, when removing node 1_2, node 1_2_2
should be marked as removed but it wasn't:
This issue with returning upwards in ancestors chain is now fixed. A
new test case is added with the above example scenario.
Resolves: #71