Commits on May 16, 2021

1. Fix removal of complex subtrees …

   Previous code had incorrect preorder traversal in
   NodeId::remove_subtree. Upon return upwards in the tree, if a cursor's
   parent didn't have a sibling, the algorithm would terminate without
   looking at more distant ancestors which still might have some siblings
   that needed removing.
   
   In the following example arena, when removing node 1_2, node 1_2_2
   should be marked as removed but it wasn't:
   
       arena
       `-- 1
           |-- 1_1
           |-- 1_2
           |   |-- 1_2_1
           |   |   `-- 1_2_1_1
           |   |       `-- 1_2_1_1_1
           |   `-- 1_2_2
           `-- 1_3
   
   This issue with returning upwards in ancestors chain is now fixed. A
   new test case is added with the above example scenario.
   
   Resolves: saschagrunert#71

   

   jistr committed May 16, 2021
   Configuration menu

   • View commit details
   • Copy full SHA for e59a038
   • Browse repository at this point

   Copy the full SHA

   e59a038 View commit details

   Browse the repository at this point in the history