Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance generator test cases to check for correct templating #45

Closed
js1972 opened this issue Feb 4, 2014 · 2 comments
Closed

Enhance generator test cases to check for correct templating #45

js1972 opened this issue Feb 4, 2014 · 2 comments
Assignees
@js1972
Labels
test

Comments

@js1972
Copy link
Collaborator

js1972 commented Feb 4, 2014

When templating a file we typically substitute some variables for the generator prompt answers. We need to add test cases that inspect and ensure these substitutions have taken place. This will stop issues such as #44 from occurring.
@js1972 js1972 self-assigned this Feb 6, 2014
@js1972
Copy link
Collaborator Author

js1972 commented Feb 7, 2014

In progress using cheerio (https://github.com/MatthewMueller/cheerio) as a jQuery-like selector engine to check index.html scaffolding.

js1972 added a commit to js1972/generator-openui5 that referenced this issue Feb 7, 2014
@js1972
test(tiles app): Added tests for index.html scaffolding
7797f17 
Added tests to ensure that index.html is templated properly with the correct variables based on user prompts

Based-on: saschakiefer#45
@js1972
Copy link
Collaborator Author

js1972 commented Feb 7, 2014

Add another assert() on the templated component namespace.

js1972 added a commit to js1972/generator-openui5 that referenced this issue Feb 12, 2014
@js1972
test(tiles app): Added extra tests for index.html scaffolding
47d8451 
Now testing for correct templating of UI5 bootstrap location, Component namespace and title in index.html.
Also removed extra whitespace from _index.html.

Based-on: saschakiefer#45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@js1972 js1972

Labels
test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@saschakiefer @js1972