Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing check arguments in cumBgGD function #15

Closed
NannaLojborg opened this issue Aug 7, 2019 · 6 comments
Closed

Missing check arguments in cumBgGD function #15

NannaLojborg opened this issue Aug 7, 2019 · 6 comments

Comments

@NannaLojborg
Copy link
Collaborator

In line 14 it says 'Check arguments', but there is nothing there. Check arguments should be added similar to how it is done in cumBg function.

@NannaLojborg
Copy link
Collaborator Author

Check arguments have been added. Though, new changes needs to be reviewed.

@sashahafner
Copy link
Owner

@NannaLojborg can you check line 60? It still seems to have a missing ). Maybe you didn't include this file in a commit. If you have committed and pushed all changes, I can fix it. Just trying to avoid a merge conflict.

@NannaLojborg
Copy link
Collaborator Author

I have added the missing bracket now. It was line 61 you noticed a missing bracket earlier and a 'c' in line 60. That is why I missed a bracket in line 60, after adding the 'c'.

@NannaLojborg
Copy link
Collaborator Author

NannaLojborg commented Aug 11, 2019

@sashahafner All changes have been committed and pushed.

@sashahafner
Copy link
Owner

Great thanks!

@sashahafner
Copy link
Owner

Looks good. I made a few minor changes. We need to test it, and for that we should make a data set for testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants