-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing check arguments in cumBgGD function #15
Comments
Check arguments have been added. Though, new changes needs to be reviewed. |
@NannaLojborg can you check line 60? It still seems to have a missing ). Maybe you didn't include this file in a commit. If you have committed and pushed all changes, I can fix it. Just trying to avoid a merge conflict. |
I have added the missing bracket now. It was line 61 you noticed a missing bracket earlier and a 'c' in line 60. That is why I missed a bracket in line 60, after adding the 'c'. |
@sashahafner All changes have been committed and pushed. |
Great thanks! |
Looks good. I made a few minor changes. We need to test it, and for that we should make a data set for testing. |
In line 14 it says 'Check arguments', but there is nothing there. Check arguments should be added similar to how it is done in cumBg function.
The text was updated successfully, but these errors were encountered: