Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to sasjs init #1305

Closed
allanbowe opened this issue Jan 4, 2023 · 2 comments · Fixed by #1307
Closed

improvements to sasjs init #1305

allanbowe opened this issue Jan 4, 2023 · 2 comments · Fixed by #1307

Comments

@allanbowe
Copy link
Member

allanbowe commented Jan 4, 2023

I noticed a few issues when running sasjs init in an existing project today:

  1. The existing package.json was destroyed, rather than updated
  2. The sasjs/sasjsconfig.json file was very large (should be minimal)
  3. The .gitignore contained an unnecessary LF

image

About the sasjs/sasjsconfig.json file - ideally it would look like the below:

{
  "$schema": "https://cli.sasjs.io/sasjsconfig-schema.json",
  "macroFolders": [
    "sasjs/macros"
  ],
  "defaultTarget": "mytarget",
  "targets": [
    {
      "name": "mytarget",
      "serverType": "SASJS",
      "serverUrl": " ",
      "appLoc": "/Public/apps/myapp"
    }
  ]
}

Since adding the schema, it's not necessary to add example configs as we have them on auto-complete.

@sabhas
Copy link
Member

sabhas commented Jan 12, 2023

via Hubstaff
User: Sabir Hassan

Project: SASjs cli - https://app.hubstaff.com/projects/2310875
Date Range: 01/05/23 - 01/06/23
Work session total: 4:31:13
Billable: Yes

Grand total: 4:31:13

@sasjsbot
Copy link

🎉 This issue has been resolved in version 3.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants