Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improvements to sasjs init #1307

Merged
merged 6 commits into from
Jan 12, 2023
Merged

fix: improvements to sasjs init #1307

merged 6 commits into from
Jan 12, 2023

Conversation

sabhas
Copy link
Member

@sabhas sabhas commented Jan 5, 2023

Issue

closes #1305

Intent

  • on sasjs init command, create minimal sasjs/sasjsconfig.json file
  • sasjs init command should not destroy existing packages.json
  • fix logic for updating the .gitignore file

Implementation

  • pass just folder name instead of whole path to isExistingProject function

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • JSDoc comments have been added or updated.
  • Reviewer is assigned.

allanbowe
allanbowe previously approved these changes Jan 5, 2023
View reviewed changes
@allanbowe allanbowe merged commit 38f313f into main Jan 12, 2023
@allanbowe allanbowe deleted the issue-1305 branch January 12, 2023 20:48
@sasjsbot
Copy link

🎉 This PR is included in version 3.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medjedovicm medjedovicm medjedovicm approved these changes

@allanbowe allanbowe allanbowe left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improvements to sasjs init
4 participants
@sabhas @sasjsbot @allanbowe @medjedovicm