Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compile-tree): fixed CompileTree and add isWindows and newLine utils #176

Merged
merged 4 commits into from
Mar 15, 2022
Merged

fix(compile-tree): fixed CompileTree and add isWindows and newLine utils #176

merged 4 commits into from
Mar 15, 2022

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Mar 15, 2022 •
edited
Loading

Intent

  • Fix removeHeader for windows systems.

Implementation

  • Added isWindows util.
  • Added newLine util.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • All unit tests are passing (npm test).
  • All sasjs-cli unit tests are passing (npm test).
  • Reviewer is assigned.

allanbowe
allanbowe approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@allanbowe allanbowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, loving the tests!

@YuryShkoda YuryShkoda merged commit eec480e into main Mar 15, 2022
@YuryShkoda YuryShkoda deleted the compile-tree-fix branch March 15, 2022 11:16
@ghost
Copy link

ghost commented Mar 15, 2022

🎉 This PR is included in version 2.38.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ghost ghost added the released label Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe approved these changes

@medjedovicm medjedovicm medjedovicm approved these changes

@VladislavParhomchik VladislavParhomchik Awaiting requested review from VladislavParhomchik

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YuryShkoda @allanbowe @medjedovicm