Skip to content

Commit

Permalink
Don't crash when writing Infinity in JS mode (#1069)
Browse files Browse the repository at this point in the history
Closes #1031
  • Loading branch information
nex3 committed Sep 4, 2020
1 parent 4c0bc7f commit 1dff9a7
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -7,6 +7,8 @@

* Improve some error messages for edge-case parse failures.

* Don't crash when writing `Infinity` in JS mode.

## 1.26.10

* Fixes a bug where two adjacent combinators could cause an error.
Expand Down
2 changes: 2 additions & 0 deletions lib/src/util/number.dart
Expand Up @@ -39,6 +39,8 @@ bool fuzzyGreaterThanOrEquals(num number1, num number2) =>

/// Returns whether [number] is [fuzzyEquals] to an integer.
bool fuzzyIsInt(num number) {
// Check this before is int to work around dart-lang/sdk#43325.
if (number.isInfinite || number.isNaN) return false;
if (number is int) return true;

// Check against 0.5 rather than 0.0 so that we catch numbers that are both
Expand Down
5 changes: 5 additions & 0 deletions test/output_test.dart
Expand Up @@ -44,6 +44,11 @@ void main() {
});

group("for floating-point numbers", () {
test("Infinity", () {
expect(compileString("a {b: 1e999}"),
equalsIgnoringWhitespace("a { b: Infinity; }"));
});

test(">= 1e21", () {
expect(compileString("a {b: 1.01e21}"),
equalsIgnoringWhitespace("a { b: 101${'0' * 19}; }"));
Expand Down

0 comments on commit 1dff9a7

Please sign in to comment.