Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the default separator for new SassArgumentList in the JS API #1580

Merged
merged 1 commit into from
Dec 31, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
## 1.45.2

### JS API

* **Potentially breaking bug fix:** Change the default value of the `separator`
parameter for `new SassArgumentList()` to `','` rather than `null`. This
matches the API specification.

## 1.45.1

* **Potentially breaking bug fix:** Properly parse custom properties in
Expand Down
3 changes: 2 additions & 1 deletion lib/src/node/value/argument_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import '../utils.dart';
/// The JavaScript `SassArgumentList` class.
final JSClass argumentListClass = () {
var jsClass = createJSClass('sass.SassArgumentList',
(Object self, Object contents, Object keywords, [String? separator]) {
(Object self, Object contents, Object keywords,
[String? separator = ',']) {
return SassArgumentList(
jsToDartList(contents).cast<Value>(),
(isImmutableMap(keywords)
Expand Down
4 changes: 4 additions & 0 deletions pkg/sass_api/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.0.0-beta.25

* No user-visible changes.

## 1.0.0-beta.24

* No user-visible changes.
Expand Down
4 changes: 2 additions & 2 deletions pkg/sass_api/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ name: sass_api
# Note: Every time we add a new Sass AST node, we need to bump the *major*
# version because it's a breaking change for anyone who's implementing the
# visitor interface(s).
version: 1.0.0-beta.24
version: 1.0.0-beta.25
description: Additional APIs for Dart Sass.
homepage: https://github.com/sass/dart-sass

environment:
sdk: '>=2.12.0 <3.0.0'

dependencies:
sass: 1.45.1
sass: 1.45.2

dependency_overrides:
sass: {path: ../..}
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: sass
version: 1.45.1
version: 1.45.2
description: A Sass implementation in Dart.
homepage: https://github.com/sass/dart-sass

Expand Down