Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix serializing loud comment crash when importing the same file twice in a row #1713

Merged
merged 2 commits into from Jun 8, 2022

Conversation

Goodwine
Copy link
Member

@Goodwine Goodwine commented Jun 7, 2022

@Goodwine Goodwine requested review from nex3 and jathak June 7, 2022 04:51
@Goodwine Goodwine changed the title fix serializing loud comment crash when importing the same file twice fix serializing loud comment crash when importing the same file twice in a row Jun 7, 2022
Copy link
Contributor

@nex3 nex3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you bump the pubspec and add a changelog entry as well?

@Goodwine Goodwine requested a review from nex3 June 7, 2022 23:05
@Goodwine
Copy link
Member Author

Goodwine commented Jun 7, 2022

Done, thanks for the reminder :D

@Goodwine Goodwine merged commit ae6275e into main Jun 8, 2022
@Goodwine Goodwine deleted the fix-1712 branch June 8, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Got range error
2 participants