test case for loud comments in file imported twice in a row #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Goodwine
commented
Jun 7, 2022
| @@ -83,7 +83,7 @@ export function compareResults( | |||
| return failures.MissingOutput(); | |||
| } else if (expected.isSuccess) { | |||
| if (!actual.isSuccess) { | |||
| return failures.UnexpectedError(); | |||
| return failures.UnexpectedError(actual.error); | |||
There was a problem hiding this comment.
BTW I should mention for context - if you look at the bug report the error is very cryptic and not easy to read at all, by adding this I found the error to be more useful
nex3
reviewed
Jun 8, 2022
nex3
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/dart-sass#1713
[skip dart-sass]