Write implementation documentation #2042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also rename Dispatcher to CompilationDispatcher for clarity
nex3
changed the title
stof
reviewed
Sep 29, 2023
Also code review
stof
approved these changes
Oct 1, 2023
jathak
approved these changes
Oct 6, 2023
|
@nex3 I would suggest merging this so that the documentation is in the repo (and future PRs might update it if needed) |
|
I'm hoping @pamelalozano16 has another chance to review. |
pamelalozano16
approved these changes
Nov 3, 2023
jgerigmeyer
added a commit
to oddbird/dart-sass
that referenced
this pull request
Nov 17, 2023
* feature.color-4: Poke CI Update link to Node.js releases page (sass#2131) Write implementation documentation (sass#2042) Remove dead code (sass#2129) Add compatibility with Node.js 21.0.0 (sass#2128) Bump lints from 2.1.1 to 3.0.0 (sass#2126) Bump dartdoc from 6.3.0 to 7.0.0 (sass#2118) Cut a release (sass#2120) Update pubspec and changelog for sass/embedded-host-node#257 (sass#2116) Fix crash in browser when running alongside NextJS (sass#2114) Cut another release (sass#2111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename Dispatcher to CompilationDispatcher for clarity