Remove dead code in the extension store #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you look into the failing specs? |
|
Based on those failures, maybe not removing the selector is the right behavior, and we should remove the line that was doing nothing. |
|
The change in |
The key being removed could not exist in the map as it is not even the same type than keys.
stof
changed the title
|
@nex3 I updated the PR to only remove the dead code. |
nex3
approved these changes
Nov 3, 2023
jgerigmeyer
added a commit
to oddbird/dart-sass
that referenced
this pull request
Nov 17, 2023
* feature.color-4: Poke CI Update link to Node.js releases page (sass#2131) Write implementation documentation (sass#2042) Remove dead code (sass#2129) Add compatibility with Node.js 21.0.0 (sass#2128) Bump lints from 2.1.1 to 3.0.0 (sass#2126) Bump dartdoc from 6.3.0 to 7.0.0 (sass#2118) Cut a release (sass#2120) Update pubspec and changelog for sass/embedded-host-node#257 (sass#2116) Fix crash in browser when running alongside NextJS (sass#2114) Cut another release (sass#2111)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sourcesMap will never containextension.extenderas it is anExtenderobject, not a ComplexSelector.I updated that by assuming that the comment just above it is true and that the selector should actually be removed.
An alternative could be to remove that line of code entirely, preserving the current behavior where nothing is removed.
The dart compiler does not catch this mistake as
Map.removeallows passing any object, not just objects matching the key type.I caught this when porting that code to PHP for the Scssphp project, where phpstan (the PHP static analyzer we use) has a different signature for the storage we use, requiring a valid key type.