Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into feature.color-4 #2204

Merged
merged 37 commits into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
13830a5
Fix new recommended lints (#2139)
nex3 Dec 5, 2023
bd80c58
Make LazyFileSpans work in JavaScript (#2142)
nex3 Dec 5, 2023
cd798bf
Improve inspect() output for complex units (#2138)
nex3 Dec 8, 2023
4daf0b4
Escape non-US-ASCII characters in `SassException.toCssString()` (#2143)
ntkme Dec 8, 2023
f5dab76
Bump dartdoc from 7.0.2 to 8.0.2 (#2146)
dependabot[bot] Dec 11, 2023
6f665c1
Escape unprintable 0x7F (delete control character) (#2144)
ntkme Dec 11, 2023
1fc740d
Upload releases for musl-libc and android (#2149)
ntkme Dec 15, 2023
f3c7be5
Make meta.apply() an AsyncBuiltInCallable (#2152)
nex3 Dec 28, 2023
6205eac
Add wait time before update website (#2153)
ntkme Dec 29, 2023
006baa5
Update the pubspec and changelog for sass/embedded-host-node#266 (#2158)
nex3 Jan 2, 2024
b263a72
Use implementation name dart-sass for VersionResponse (#2156)
ntkme Jan 16, 2024
0d91c92
Support CompileRequest.silent of embedded protocol (#2160)
ntkme Jan 16, 2024
076414d
[Shared Resources] dart-sass implementation (#2134)
jerivas Jan 18, 2024
bbf97b4
Remove the sass dependency from package.json (#2162)
nex3 Jan 19, 2024
9423aa5
Use macos-14 runner instead of macos-latest-xlarge runner (#2167)
ntkme Feb 1, 2024
9ee5408
[Package Importer] Dart Implementation (#2130)
jamesnw Feb 6, 2024
84f31f0
Update pubspec/changelog for `pkg:` importers (#2168)
nex3 Feb 7, 2024
00571ec
Add a `--pkg-importer` flag (#2169)
nex3 Feb 12, 2024
84ededd
Use musl support in cli_pkg (#2172)
ntkme Feb 13, 2024
2cab33e
Update the language revision in Homebrew on release (#2171)
nex3 Feb 15, 2024
3e6721e
Fix new static warnings with Dart 3.3 (#2173)
nex3 Feb 16, 2024
786dd63
Fix linux musl builds (#2175)
ntkme Feb 20, 2024
85a932f
Add missing ESM export of NodePackageImporter (#2177)
jgerigmeyer Feb 20, 2024
6d66c43
Properly handle `new NodePackageImporter()` with an ESM entrypoint (#…
nex3 Feb 21, 2024
1b4d703
Release 1.71.1 (#2182)
nex3 Feb 21, 2024
fd67fe6
[Hotfix Node Package Importer]- Handle subpath without extensions (#2…
jamesnw Mar 5, 2024
fa4d909
Bump softprops/action-gh-release from 1 to 2 (#2191)
dependabot[bot] Mar 11, 2024
6e2d637
Allow adjacent forward slashes in plain CSS expressions (#2190)
nex3 Mar 12, 2024
48e2d0c
Preserve underscores in `VariableExpression.toString()` (#2185)
nex3 Mar 12, 2024
0330491
Update to node 20 (#2192)
ntkme Mar 12, 2024
9af6bbf
Properly handle `pkg:` imports with args (#2193)
nex3 Mar 12, 2024
ce16b35
Cut a release (#2194)
nex3 Mar 13, 2024
772280a
Support linux-riscv64 and windows-arm64 (#2201)
ntkme Mar 19, 2024
9302b35
Add support for nesting in plain CSS (#2198)
nex3 Mar 22, 2024
c8d0643
Better handle filesystem importers when load paths aren't necessary (…
nex3 Mar 27, 2024
3a8a618
Merge branch 'main' of github.com:sass/dart-sass into feature.color-4
nex3 Mar 27, 2024
5808b84
Poke CI
nex3 Mar 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/util/initialize/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Initialize
description: Check out Dart Sass and build the embedded protocol buffer.
inputs:
github-token: {required: true}
node-version: {required: false, default: 18}
node-version: {required: false, default: 'lts/*'}
dart-sdk: {required: false, default: stable}
architecture: {required: false}
runs:
Expand All @@ -13,7 +13,7 @@ runs:
sdk: "${{ inputs.dart-sdk }}"
architecture: "${{ inputs.architecture }}"

- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "${{ inputs.node-version }}"

Expand All @@ -23,7 +23,7 @@ runs:
- run: npm install
shell: bash

- uses: bufbuild/buf-setup-action@v1.13.1
- uses: bufbuild/buf-setup-action@v1.30.0
with: {github_token: "${{ inputs.github-token }}"}

- name: Check out the language repo
Expand Down
75 changes: 75 additions & 0 deletions .github/workflows/build-android.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
name: Build for android

on:
workflow_call:
workflow_dispatch:

jobs:
build:
name: Build

runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
include:
- arch: x64
lib: lib64
platform: linux/amd64
- arch: ia32
lib: lib
platform: linux/amd64
- arch: arm64
lib: lib64
platform: linux/arm64
- arch: arm
lib: lib
platform: linux/arm64
# There is no docker image for riscv64 dart-sdk, build kernel snapshot instead.
- arch: riscv64
lib: lib64
platform: linux/amd64 # linux/riscv64

steps:
- uses: actions/checkout@v4

- name: Set up QEMU
uses: docker/setup-qemu-action@v3
with:
image: tonistiigi/binfmt:master # need qemu >= 7.0.0

- name: Compile Protobuf
run: |
docker run --rm -i \
--volume "$PWD:$PWD" \
--workdir "$PWD" \
docker.io/library/dart <<'EOF'
set -e
curl -fsSL -H "Authorization: Bearer ${{ github.token }}" "https://github.com/bufbuild/buf/releases/latest/download/buf-$(uname -s)-$(uname -m).tar.gz" | tar -xzC /usr/local --strip-components 1
dart pub get
dart run grinder protobuf
EOF

- name: Build
run: |
docker run --rm -i \
--platform ${{ matrix.platform }} \
--privileged \
--volume "$PWD:$PWD" \
--workdir "$PWD" \
ghcr.io/dart-android/dart <<'EOF'
set -e
export DART_SDK=/system/${{ matrix.lib }}/dart
export PATH=$DART_SDK/bin:$PATH
dart pub get
dart run grinder pkg-standalone-android-${{ matrix.arch }}
EOF

- name: Upload Artifact
uses: actions/upload-artifact@v4
with:
name: build-android-${{ matrix.arch }}
path: build/*.tar.gz
if-no-files-found: error
compression-level: 0
69 changes: 69 additions & 0 deletions .github/workflows/build-linux-musl.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,69 @@
name: Build for linux-musl

on:
workflow_call:
workflow_dispatch:

jobs:
build:
name: Build

runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
include:
- arch: x64
platform: linux/amd64
- arch: ia32
platform: linux/386
- arch: arm64
platform: linux/arm64
# There is a bug in qemu's mremap causing pthread_getattr_np in musl to stuck in a loop on arm.
# Unless qemu fixes the bug or we get a real linux-arm runner, we cannot build aot-snapshot
# for arm on CI. So, we create a kernel snapshot for arm build in amd64 container instead.
# https://gitlab.com/qemu-project/qemu/-/issues/1729
- arch: arm
platform: linux/amd64 # linux/arm/v7
# There is no docker image for riscv64 dart-sdk, build kernel snapshot instead.
- arch: riscv64
platform: linux/amd64 # linux/riscv64

steps:
- uses: actions/checkout@v4

- name: Set up QEMU
uses: docker/setup-qemu-action@v3

- name: Compile Protobuf
run: |
docker run --rm -i \
--volume "$PWD:$PWD" \
--workdir "$PWD" \
docker.io/library/dart <<'EOF'
set -e
curl -fsSL -H "Authorization: Bearer ${{ github.token }}" "https://github.com/bufbuild/buf/releases/latest/download/buf-$(uname -s)-$(uname -m).tar.gz" | tar -xzC /usr/local --strip-components 1
dart pub get
dart run grinder protobuf
EOF

- name: Build
run: |
docker run --rm -i \
--platform ${{ matrix.arch == 'arm' && 'linux/amd64' || matrix.platform }} \
--volume "$PWD:$PWD" \
--workdir "$PWD" \
ghcr.io/dart-musl/dart <<'EOF'
set -e
dart pub get
dart run grinder pkg-standalone-linux-${{ matrix.arch }}-musl
EOF

- name: Upload Artifact
uses: actions/upload-artifact@v4
with:
name: build-linux-musl-${{ matrix.arch }}
path: build/*.tar.gz
if-no-files-found: error
compression-level: 0
66 changes: 66 additions & 0 deletions .github/workflows/build-linux.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,66 @@
name: Build for linux

on:
workflow_call:
workflow_dispatch:

jobs:
build:
name: Build

runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
include:
- arch: x64
platform: linux/amd64
- arch: ia32
platform: linux/amd64
- arch: arm
platform: linux/arm/v7
- arch: arm64
platform: linux/arm64
# There is no docker image for riscv64 dart-sdk, build kernel snapshot instead.
# https://github.com/dart-lang/dart-docker/issues/96#issuecomment-1669860829
- arch: riscv64
platform: linux/amd64 # linux/riscv64

steps:
- uses: actions/checkout@v4

- name: Set up QEMU
uses: docker/setup-qemu-action@v3

- name: Compile Protobuf
run: |
docker run --rm -i \
--volume "$PWD:$PWD" \
--workdir "$PWD" \
docker.io/library/dart <<'EOF'
set -e
curl -fsSL -H "Authorization: Bearer ${{ github.token }}" "https://github.com/bufbuild/buf/releases/latest/download/buf-$(uname -s)-$(uname -m).tar.gz" | tar -xzC /usr/local --strip-components 1
dart pub get
dart run grinder protobuf
EOF

- name: Build
run: |
docker run --rm -i \
--platform ${{ matrix.platform }} \
--volume "$PWD:$PWD" \
--workdir "$PWD" \
docker.io/library/dart:latest <<'EOF'
set -e
dart pub get
dart run grinder pkg-standalone-linux-${{ matrix.arch }}
EOF

- name: Upload Artifact
uses: actions/upload-artifact@v4
with:
name: build-linux-${{ matrix.arch }}
path: build/*.tar.gz
if-no-files-found: error
compression-level: 0
37 changes: 37 additions & 0 deletions .github/workflows/build-macos.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
name: Build for macos

on:
workflow_call:
workflow_dispatch:

jobs:
build:
name: Build

runs-on: ${{ matrix.runner }}

strategy:
fail-fast: false
matrix:
include:
- arch: x64
runner: macos-13
- arch: arm64
runner: macos-14

steps:
- uses: actions/checkout@v4

- uses: ./.github/util/initialize
with: {github-token: "${{ github.token }}"}

- name: Build
run: dart run grinder pkg-standalone-macos-${{ matrix.arch }}

- name: Upload Artifact
uses: actions/upload-artifact@v4
with:
name: build-macos-${{ matrix.arch }}
path: build/*.tar.gz
if-no-files-found: error
compression-level: 0
39 changes: 39 additions & 0 deletions .github/workflows/build-windows.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: Build for windows

on:
workflow_call:
workflow_dispatch:

jobs:
build:
name: Build

runs-on: ${{ matrix.runner }}

strategy:
fail-fast: false
matrix:
include:
- arch: x64
runner: windows-latest
- arch: ia32
runner: windows-latest
- arch: arm64
runner: windows-latest

steps:
- uses: actions/checkout@v4

- uses: ./.github/util/initialize
with: {github-token: "${{ github.token }}"}

- name: Build
run: dart run grinder pkg-standalone-windows-${{ matrix.arch }}

- name: Upload Artifact
uses: actions/upload-artifact@v4
with:
name: build-windows-${{ matrix.arch }}
path: build/*.zip
if-no-files-found: error
compression-level: 0