Add deprecation warnings for hex alpha colors #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmesserly
approved these changes
Jun 22, 2018
| red = (red << 4) + green; | ||
| green = (blue << 4) + _hexDigit(); | ||
| blue = (_hexDigit() << 4) + _hexDigit(); | ||
| var digit1 = _hexDigit(); |
There was a problem hiding this comment.
Like this change to split the variables into digit1/2/3 initially and then red/green/blue once we figure out what a digit means. 👍
There was a problem hiding this comment.
Yeah, when I started to re-read this function I had a big confusion moment because of the old naming.
Also support unambiguous hex alpha colors. Closes #360 See sass/sass#2179
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also support unambiguous hex alpha colors.
Closes #360
See sass/sass#2179
See sass/sass-spec#1262