Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sass incorrectly parses #RRGGBBAA codes #360

Closed
michaelkolber opened this issue Jun 18, 2018 · 1 comment
Closed

Sass incorrectly parses #RRGGBBAA codes #360

michaelkolber opened this issue Jun 18, 2018 · 1 comment

Comments

@michaelkolber
Copy link

When writing something such as

box-shadow: #0000006e 0 3px 5px 0px;

Sass outputs

box-shadow: #000000 6e 0 3px 5px 0px;

which breaks the property.
nex3 added a commit that referenced this issue Jun 20, 2018
@nex3
Add deprecation warnings for hex alpha colors
c196c16 
Also support unambiguous hex alpha colors.

Closes #360
See sass/sass#2179
@nex3 nex3 mentioned this issue Jun 20, 2018
Merged
@nex3
Copy link
Contributor

nex3 commented Jun 21, 2018

Well this is definitely incorrect--in no world should the token #0000006e be parsed as a color followed by an identifier. This also reminds me that Dart Sass should be emitting deprecation warnings for hex colors that are ambiguous with IDs, a la sass/sass#2179, so that we can eventually support parsing them as colors.

nex3 added a commit that referenced this issue Jun 22, 2018
@nex3
Add deprecation warnings for hex alpha colors
4ea9a67 
Also support unambiguous hex alpha colors.

Closes #360
See sass/sass#2179
@nex3 nex3 closed this as completed in #367 Jun 22, 2018
nex3 added a commit that referenced this issue Jun 22, 2018
@nex3
Add deprecation warnings for hex alpha colors (#367)
023bf91 
Also support unambiguous hex alpha colors.

Closes #360
See sass/sass#2179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @michaelkolber