Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python script sassc renaming ? #134

Closed
frediz opened this issue Mar 10, 2016 · 8 comments · Fixed by #379
Closed

Python script sassc renaming ? #134

frediz opened this issue Mar 10, 2016 · 8 comments · Fixed by #379

Comments

@frediz
Copy link

frediz commented Mar 10, 2016

Hi,
libsass-python provides a sassc utility in python.
The name "sassc" means "Sass implemented in C", and it can collide with the binary sassc from the original project in C, when installing.
Would it make sense to rename the python utility from sassc to pysassc ?

Fred

@dahlia
Copy link
Member

dahlia commented Mar 10, 2016

The name "sassc" means "Sass implemented in C"

Although I've believed sassc means “SASS Compiler,”, yes, it can collide with sassc provided by SassC. Its main purpose is to provide a drop-in-replacement of that.

@frediz
Copy link
Author

frediz commented Mar 10, 2016

I see.
So is there some plan to make the command line utilities converge ?
Because at the moment, python sassc is not totally a replacement to sassc.
In the versions below, the usage are a bit different :

sassc 3.3.2 :

Usage: sassc [options] [INPUT] [OUTPUT]

Options:
   -s, --stdin             Read input from standard input instead of an input file.
   -t, --style NAME        Output style. Can be: nested, expanded, compact, compressed.
   -l, --line-numbers      Emit comments showing original line numbers.
       --line-comments
   -I, --load-path PATH    Set Sass import path.
   -P, --plugin-path PATH  Set path to autoload plugins.
   -m, --sourcemap         Emit source map.
   -M, --omit-map-comment  Omits the source map url comment.
   -p, --precision         Set the precision for numbers.
   -v, --version           Display compiled versions.
   -h, --help              Display this help message.

sassc 0.9.3 from libsass-python :

Usage: sassc [options] SCSS_FILE [OUT_CSS_FILE]

Options:
  --version             show program's version number and exit
  -h, --help            show this help message and exit
  -s STYLE, --output-style=STYLE
                        Coding style of the compiled result.  Choose one of
                        nested, expanded, compact, or compressed. [default:
                        nested]
  -m, -g, --sourcemap   Emit source map.  Requires the second argument (output
                        css filename).
  -I DIR, --include-path=DIR
                        Path to find "@import"ed (S)CSS source files.  Can be
                        multiply used.
  -w, --watch           Watch file for changes.  Requires the second argument
                        (output css filename).
  -p PRECISION, --precision=PRECISION
                        Set the precision for numbers. [default: 5]

@dahlia
Copy link
Member

dahlia commented Mar 10, 2016

I believe all options provided by SassC except -P/--plugin-path can be covered.

@asottile
Copy link
Member

fwiw I kind of agree with @frediz -- perhaps we can have a migration period where we provide pysassc and sassc (the debian packaging can choose to delete sassc so we don't conflict with https://github.com/sass/sassc) and we can phase out sassc over a few releases

@dahlia
Copy link
Member

dahlia commented Mar 10, 2016

If we had some statistics about its usage the decision could be way
easier. Although it’s just an anecdote of mine, some private projects of
my work actually use libsass-python’s sassc command. Thanks to its
compatible interface to the original sassc command, I don’t have to install
the original one, but libsass-python is enough to run these programs (which
internally popens sassc command). I am not sure whether it’s just me or
typical usage, but if it’s not that unusual way to use it I also agree to
rename the command to pysassc. 😉

On Fri, Mar 11, 2016, 3:29 AM Anthony Sottile notifications@github.com
wrote:

fwiw I kind of agree with @frediz https://github.com/frediz -- perhaps
we can have a migration period where we provide pysassc and sassc (the
debian packaging can choose to delete sassc so we don't conflict with
https://github.com/sass/sassc) and we can phase out sassc over a few
releases


Reply to this email directly or view it on GitHub
#134 (comment)
.

@asottile
Copy link
Member

Here's the release plan for this from here:

  • next release: add pysassc
  • next next release: issue deprecation warning in sassc
  • (some time after): change warning to error
  • (some time after): remove sassc

@mgreter
Copy link
Contributor

mgreter commented Jan 12, 2018

FWIW. I named the cli tool in perl-libsass "psass". I would probably have named the python cli the same, but maybe pysass would also be an option (not sure why you want to keep the "c" in there)? Since perl-libsass includes the complete libsass dependency, it optionally also can compile/install the official sassc binary (which links to the same libsass library as perl consumes). This is especially useful to share the same plugins (also in the same .so/.dll/.dynlib format, linking to the one shared LibSass lib). This way one can install the complete LibSass ecosystem by installing the perl bindings via cpan. I believe a similar approach might be possible for python-libsass, although I have to say it required quite some tinkering with the build system for the perl bindings. But after some try and error it works now on all major systems (linux/windows/osx).

@asottile
Copy link
Member

Sounds good -- we're in the migration process to an executable named pysassc (python sass compiler) and will be slowly deprecating and phasing out the old name. 🔜 ™️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants