Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block comment after numbers throws error #1021

Closed
mgol opened this issue Apr 1, 2015 · 0 comments · Fixed by #1027
Closed

Block comment after numbers throws error #1021

mgol opened this issue Apr 1, 2015 · 0 comments · Fixed by #1027
Assignees
@mgreter
Labels
Bug - Confirmed Dev - Test Written
Milestone
3.2

Comments

@mgol
Copy link

mgol commented Apr 1, 2015

The following SCSS:

div {
    top: 10px - 2 * 5px /* arrow size */;
}

causes an error:

>> error reading values after /
>>   Line 2  Column 25  app/modules/components/base/item-panel/item-panel-sidebar/_item-panel-sidebar.tmp.scss

node-sass 3.0.0-beta.4. Ruby Sass parses it fine.

This is similar to #890.
@mgol mgol mentioned this issue Apr 1, 2015
Closed
@mgreter mgreter added this to the 3.2 milestone Apr 1, 2015
@mgreter mgreter self-assigned this Apr 1, 2015
@mgreter mgreter changed the title Comment at the end of the rule causes an error Block comment after numbers throws error Apr 1, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Apr 1, 2015
@mgreter
Fix parsing of another missed block comment
074108a 
Fixes sass#1021
mgreter added a commit to mgreter/libsass that referenced this issue Apr 1, 2015
@mgreter
Fix parsing of another missed block comment
7bdcd6a 
Fixes sass#1021
@mgreter mgreter mentioned this issue Apr 1, 2015
Merged
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Activate libsass todo test for issue 1021
b886e17 
sass/libsass#1021
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Activate libsass todo test for issue 1021
e0d4e3b 
sass/libsass#1021
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Activate libsass todo test for issue 1021
3e55b6a 
sass/libsass#1021
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Activate libsass todo test for issue 1021
06c8e6c 
sass/libsass#1021
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Activate libsass todo test for issue 1021
760ca7e 
sass/libsass#1021
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Add todo spec test for libsass issue 1021
77baa2e 
sass/libsass#1021
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Add todo spec test for libsass issue 1021
152165b 
sass/libsass#1021
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Add todo spec test for libsass issue 1021
b43e815 
sass/libsass#1021
@mgreter mgreter mentioned this issue Apr 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgreter mgreter

Labels
Bug - Confirmed Dev - Test Written
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

Fix parsing of another missed block comment mgreter/libsass
2 participants
@mgreter @mgol