Fix url parsing with trailing spaces in url #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-factoring in lexer to make args more consistent. Added loosely match that can be preceded by spaces.
mgreter
force-pushed
the
bugfix/url-trailing-spaces
branch
from
717a05d
to
51b0bf0
Compare
mgreter
added a commit
that referenced
this pull request
Apr 7, 2015
Fix url parsing with trailing spaces in url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-factoring in lexer to make args more consistent.
Added loosely match that can be preceded by spaces.
Makes it pass spec test: