Regression in parsing @at-rules

[xzyfer]

This regression was introduced 3.2.4.

@mixin keyframes($animation-name) {
  @keyframes $animation-name {
    @content;
  }
}

@include keyframes(bounce) {
  0%, 20%, 50%, 80%, 100% {transform: translateY(0);}
  40% {transform: translateY(-30px);}
  60% {transform: translateY(-15px);}
}

Ruby Sass

@keyframes $animation-name {
  0%, 20%, 50%, 80%, 100% {
    transform: translateY(0); }
  40% {
    transform: translateY(-30px); }
  60% {
    transform: translateY(-15px); } }

Libsass 3.2.4

Error: invalid selector after
        on line 2 of test.scss
>>   @keyframes $animation-name {
   ------------^

Spec added: sass/sass-spec#387

[saper]

(accoring to git bisect 974ae42 broke this, it was introduced in #1177)

[xzyfer]

This is fixed and will be 3.2.5.

[xzyfer]

I appear to have misunderstood this issue.

[Chocanto]

Issue still opened ? Is this bug not fixed ?

[xzyfer]

@Chocanto It no longer errors, however it acts different to Ruby Sass.

[xzyfer]

I'm closing this issue since the OP was regarding an error being thrown, which has been addressed.

I've opened #1253 to track the difference in output.

[Chocanto]

@xzyfer Wow, nice work. Thank you ! :)

[mgreter]

We now have a passing spec test since #1249 was merged 🎈