Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement correct String Schema parsing #1177

Merged
merged 1 commit into from
May 9, 2015
Merged

Implement correct String Schema parsing #1177

merged 1 commit into from
May 9, 2015

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented May 8, 2015

Declaration values should be parsed as a string-schema if
it contains any interpolations. To decide this we need to
look-ahead, as we already do with selectors and mixins.

Fixes #1158

@mgreter mgreter self-assigned this May 8, 2015
@mgreter mgreter added this to the 3.2.3 milestone May 8, 2015
@mgreter mgreter mentioned this pull request May 8, 2015
Merged
@mgreter mgreter mentioned this pull request May 9, 2015
Merged
mgreter added a commit to mgreter/libsass that referenced this pull request May 9, 2015
@mgreter
* Merge more fixes and features for 3.2.3
639ab5e 
- sass#1177
- sass#1180
- sass#1181
- sass#1182
- sass#1183
- sass#1184
@mgreter
Implement correct String Schema parsing
974ae42 
Declaration values should be parsed as a string-schema if
it contains any interpolations. To decide this we need to
look-ahead, as we already do with selectors and mixins.

Fixes sass#1158
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 80.18% when pulling 974ae42 on mgreter:bugfix/issue_1158 into 348fde8 on sass:master.

mgreter added a commit that referenced this pull request May 9, 2015
@mgreter
Merge pull request #1177 from mgreter/bugfix/issue_1158
8768c44 
Implement correct String Schema parsing
@mgreter mgreter merged commit 8768c44 into sass:master May 9, 2015
@mgreter mgreter deleted the bugfix/issue_1158 branch May 9, 2015 04:30
This was referenced May 15, 2015
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgreter mgreter

Labels
Dev - PR Ready Dev - Test Written
Projects
None yet
Milestone
3.2.3
Development

Successfully merging this pull request may close these issues.

Variable concatenation with interpolation adds a space in between
2 participants
@mgreter @coveralls