Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support hex colors with alpha channels #2674

Closed
nex3 opened this issue Jun 21, 2018 · 0 comments
Closed

Support hex colors with alpha channels #2674

nex3 opened this issue Jun 21, 2018 · 0 comments
Assignees
@xzyfer
Labels
Dev - PR Ready Dev - Test Written

Comments

@nex3
Copy link
Contributor

nex3 commented Jun 21, 2018

Language issue: sass/sass#2179
Specs: sass/sass-spec#1262

#2302 deprecated the old behavior, but that's been out long enough that it's probably fine for LibSass to add support for the new behavior whenever.
@lepe lepe mentioned this issue Jun 21, 2018
Closed
3 tasks
xzyfer added a commit to xzyfer/libsass that referenced this issue Jul 26, 2018
@xzyfer
Support hex colors with alpha channels
b2d6ed5 
A deprecation for the old behaviour landed in sass#2302. This PR removes
the deprecation warning for the old behaviour, and starts parsing
4 and 8 digit hex values as Colors.

Looks like we had support for 8 digit hex colors for a while but
somehow 4 digit support was missed.

Spec sass/sass-spec#1273

Fixes sass#2674
@xzyfer xzyfer mentioned this issue Jul 26, 2018
Merged
@xzyfer xzyfer self-assigned this Jul 26, 2018
xzyfer added a commit that referenced this issue Jul 26, 2018
@xzyfer
Support hex colors with alpha channels
fbdcc37 
A deprecation for the old behaviour landed in #2302. This PR removes
the deprecation warning for the old behaviour, and starts parsing
4 and 8 digit hex values as Colors.

Looks like we had support for 8 digit hex colors for a while but
somehow 4 digit support was missed.

Spec sass/sass-spec#1273

Fixes #2674
xzyfer added a commit that referenced this issue Nov 11, 2018
@xzyfer
Support hex colors with alpha channels
7459d19 
A deprecation for the old behaviour landed in #2302. This PR removes
the deprecation warning for the old behaviour, and starts parsing
4 and 8 digit hex values as Colors.

Looks like we had support for 8 digit hex colors for a while but
somehow 4 digit support was missed.

Spec sass/sass-spec#1273

Fixes #2674
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xzyfer xzyfer

Labels
Dev - PR Ready Dev - Test Written
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nex3 @xzyfer