Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments before pseudo selector interpolations ::#{$variable} cause shifts in error line number reporting #533

Closed
drewwells opened this issue Oct 12, 2014 · 3 comments · Fixed by #927

Comments

@drewwells
Copy link
Contributor

This is a big bug since it throws off error line numbers for the rest of the stylesheet.

I made a couple sassmeister libsass v 2.0.0, I found this to be the case in 3.0rc4 too (thanks for releasing so often guys!). It looks like errors in interpolation syntax within a control structure with a line comment directly preceding it causes a line number to be missed.

@mixin
http://sassmeister.com/gist/5d0b00544a4738305617
@if
http://sassmeister.com/gist/9560513eae9c2f9752f5

I could only reproduce this when using pseudo selector interpolation. I found this when importing bourbon's placeholder sass
https://github.com/thoughtbot/bourbon/blob/71a7e61cfbc9975dcea6836aee7ecdaeb93861fa/app/assets/stylesheets/css3/_placeholder.scss

@drewwells drewwells changed the title Comments in control structures (mixin, if) cause shifts in error line number reporting Comments before pseudo selector interpolations ::#{$variable} cause shifts in error line number reporting Oct 12, 2014
@drewwells
Copy link
Contributor Author

@mgreter are there sass specs for the accuracy of error line numbers?

@xzyfer
Copy link
Contributor

xzyfer commented Jan 11, 2015

There are currently no specs in Libsass, but @mgreter has some in perl-sass. There's more information in this thread #786 (comment)

mgreter added a commit to mgreter/libsass that referenced this issue Mar 8, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Mar 8, 2015
@mgreter mgreter self-assigned this Mar 8, 2015
@mgreter mgreter added this to the 3.2 milestone Mar 8, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Mar 8, 2015
@drewwells
Copy link
Contributor Author

This has been working since some changes on master (not sure when). Verified working on @5757248ae13c6b7362949637ecb1a2de7ef6d426

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants