Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Sass::round function #1688

Merged
merged 1 commit into from
Nov 3, 2015
Merged

Implement Sass::round function #1688

merged 1 commit into from
Nov 3, 2015

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Nov 3, 2015

Cherry picked from #1621

This PR implements Sass::round which emulates Ruby Sass' elipson rounding. This allows us to bump sass-spec to 3.4.15. One step closer to 3.4.19 which will come after my static value parsing refactor is complete.

Spec sass/sass-spec#590
Closes #1621

@xzyfer xzyfer added this to the 3.3.2 milestone Nov 3, 2015
@xzyfer
Copy link
Contributor Author

xzyfer commented Nov 3, 2015

Interestingly this is failing on OSX builds.

This was due to API rate limiting.

@xzyfer xzyfer force-pushed the feat/color-rounding branch 4 times, most recently from c2eba53 to 58e88cd Compare November 3, 2015 05:37
@xzyfer
Copy link
Contributor Author

xzyfer commented Nov 3, 2015

@mgreter AFAIK Sass::Util::round doesn't care about precession. That is for the output stage. I've removed it from this PR. Feel free to add it back if there is a specific need for it. I'm not aware of one.

xzyfer added a commit that referenced this pull request Nov 3, 2015
@xzyfer
Merge pull request #1688 from xzyfer/feat/color-rounding
b8db8c5 
Implement `Sass::round` function
@xzyfer xzyfer merged commit b8db8c5 into sass:master Nov 3, 2015
@xzyfer xzyfer deleted the feat/color-rounding branch November 3, 2015 05:58
@mgreter
Copy link
Contributor

mgreter commented Nov 3, 2015

@xzyfer IMHO 0.00001 means that it has an epsilon for precision of 5 and should be different for other precision options. IMHO this is a ruby sass bug ... (//CC @chriseppstein)

@xzyfer
Copy link
Contributor Author

xzyfer commented Nov 3, 2015

That's not our decision to make. Ruby Sass bugs are LibSass features.
On 4 Nov 2015 6:53 am, "Marcel Greter" notifications@github.com wrote:

@xzyfer https://github.com/xzyfer IMHO 0.00001 means that it has an
epsilon for precision of 5 and should be different for other precision
options. IMHO this is a ruby sass bug ...

—
Reply to this email directly or view it on GitHub
#1688 (comment).

@mgreter
Copy link
Contributor

mgreter commented Nov 4, 2015

sass/sass#1883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgreter mgreter

Labels
Bug - Confirmed Dev - PR Ready Dev - Test Written
Projects
None yet
Milestone
3.3.2
Development

Successfully merging this pull request may close these issues.
2 participants
@xzyfer @mgreter