-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace to_string
compare with ==
object compare
#2315
Conversation
934e1be
to
e408584
Compare
This has some unexpected failures in https://ci.appveyor.com/project/sass/libsass/build/1.0.3068/job/ih3by0c12b0fc0jv! Needs further investigations ... |
Seems this is a bit too early. The failing spec test is |
404b591
to
cc68f76
Compare
It seems I was able to fix the issue. Not it is failing only the expected spec test. |
Up on further review this needs some more changes as it is not equivalent to ruby sass now. There seems to be some path in |
ebf89a6
to
c84ac17
Compare
Extracted from sass#2315
Extracted from sass#2315
This a follow up for sass/sass#2229. This breaks a spec test which should hopefully be the same when sass/sass#2232 is released. There might be more cases where we use
to_string
to compare objects. This could lead to some regressions, as I think the compare functions do lack some edge cases. But we want them to surface, as we already use them in our hash map implementation. It is also faster than converting to a string before (specially if we can determine inequality early).